Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Right To Left Culture .net5 issue #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aburakab
Copy link

Starting from .net5 Right to left Culture. Any string with "-1" will be printed "1-" (check the image below)

image

Also, the hangfire/console API expecting "-1" to stop polling logs. But it will never reach "-1". The server will send it "1-" (check the image below)

image

@khellang
Copy link

khellang commented Nov 2, 2023

There's now a forked version with some modernization and bugfixes now on NuGet.org. Hopefully this project will come back to life at some point and the fixes can be accepted upstream 😄

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

  1. Namespace Imports:
    o Old Code: The old code includes using System.Threading;.
    o New Code: The new code removes using System.Threading;.
  2. Unused Namespaces:
    o The removal of System.Threading suggests that threading functionality is no longer used in the Hangfire.Console.Dashboard namespace.
    Improvements Needed
  3. Code Cleanliness:
    o Ensure that all unused namespaces are removed to keep the code clean and improve readability.
    o Check for any other unused namespaces that might still be present in the code.
  4. Threading:
    o If threading was previously used, ensure that its removal does not affect the functionality. Verify that any code dependent on threading is refactored or removed appropriately.
  5. Documentation:
    o Document the changes, especially if threading was involved. This includes comments or documentation on why threading was removed and what impact it might have.
  6. Testing:
    o Perform thorough testing to ensure that the removal of System.Threading does not introduce any bugs or performance issues.
  7. Consistency:
    o Maintain consistency in the coding style and structure. Ensure that the rest of the codebase follows the same conventions.
    Summary
    The new code removes the System.Threading namespace, which suggests that threading functionality is no longer needed. Ensure that this change does not negatively impact the existing functionality and that the code remains clean and well-documented. Proper testing and consistency checks should be performed to maintain code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants